プロジェクト設定ファイル内のLinkタスクの記述位置を移動する #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanomari
commented
Jan 27, 2022
| @@ -110,26 +110,26 @@ | |||
| <DebugInformationFormat>ProgramDatabase</DebugInformationFormat> | |||
| <StringPooling>true</StringPooling> | |||
| </ClCompile> | |||
| <ResourceCompile> | |||
| <PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions> | |||
| </ResourceCompile> | |||
There was a problem hiding this comment.
ここは、編集意図と異なる差分になっています。
移動したのは <Link> で、<ResourceCompile> ではありません。
|
Kudos, SonarCloud Quality Gate passed!
|
|
✅ Build sakura 1.0.4010 completed (commit 890419a4d8 by @sanomari) |
ghost
approved these changes
Jan 28, 2022
|
ありがとうございます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
プロジェクト設定ファイル内のタスク順を実際のビルド順と合わせて、プロジェクト設定を読みやすくします。
カテゴリ
PR の背景
これは #1776 に対するカウンターPRです。
わたしが同意できた部分だけを切り出したPRを作ってみました。
PR のメリット
PR のデメリット (トレードオフとかあれば)
仕様・動作説明
ビルド設定ファイル
sakura.vcxprojの読みやすさに影響する変更です。やったことは
<Link>のブロックをカットして<ResourceCompile>の後にペーストしただけです。PR の影響範囲
ビルド設定ファイル
sakura.vcxprojの読みやすさに影響します。テスト内容
テスト1
手順
関連 issue, PR
#1776
#1730
参考資料