Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basis 配下のファイルを UTF-8 (BOM付) に単純変換 #247

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

kobake
Copy link
Member

@kobake kobake commented Jul 12, 2018

該当フォルダ内の文字コードをすべて UTF-8 (BOM付) に変換しました。

cd sakura_core/basis
nkf --overwrite --oc=UTF-8-BOM *.cpp
nkf --overwrite --oc=UTF-8-BOM *.h

確認方法

WinMerge で変更前と変更後を比較すると、文字コード以外の変更が無いことが確認できます。

関連 Issues

ソースコードのUnicode化 #112

cd sakura_core/basis
nkf --overwrite --oc=UTF-8-BOM *.cpp
nkf --overwrite --oc=UTF-8-BOM *.h
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。
21ファイル・・・確認したよ。

@kobake
Copy link
Member Author

kobake commented Jul 13, 2018

PR作成よりもレビューのほうが大変な例……。レビューありがとうございます 🙏

@kobake kobake merged commit 1eb2adb into sakura-editor:master Jul 13, 2018
@m-tmatma m-tmatma added this to the next release milestone Jul 25, 2018
@m-tmatma m-tmatma added the refactoring リファクタリング 【ChangeLog除外】 label Jul 25, 2018
@kobake kobake deleted the basis-utf8 branch July 26, 2018 03:11
@ds14050 ds14050 added the refactoring リファクタリング 【ChangeLog除外】 label Sep 18, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
basis 配下のファイルを UTF-8 (BOM付) に単純変換
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring リファクタリング 【ChangeLog除外】
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants