ビルド関連のバッチファイルのエラー耐性を上げる #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
reviewed
Aug 25, 2018
build-all.bat
Outdated
| @echo %~nx1 Win32 Debug | ||
| @echo %~nx1 x64 Release | ||
| @echo %~nx1 x64 Release | ||
| exit /b |
There was a problem hiding this comment.
#361 で指摘したのと同じです。
戻り値を指定しないなら exit /b を書く意味はないと思います。
しかも、この命令文が実行されるのは call で呼ばれるサブプロセスなので、exit /bが呼ばれる時点ではこのバッチの処理は終了せず、callから戻った exit /b 1 でやっと終了することになるはずです。
ざっと見、他ファイルも同様です。
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…ild-batch ビルド関連のバッチファイルのエラー耐性を上げる
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ビルド関連のバッチファイルのエラー耐性を上げる