Visual Studio Install options を修正(#6 の反映など) #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
requested changes
Oct 5, 2018
README.md
Outdated
| @@ -46,9 +46,11 @@ https://github.com/sakura-editor/sakura/wiki | |||
| - [Visual Studio Community 2017](https://www.visualstudio.com/downloads/) | |||
|
|
|||
| #### Visual Studio Install options required | |||
| - Windows SDK | |||
| - Windows 10 SDK (10.0.17134.0) | |||
There was a problem hiding this comment.
Windows sdkがいらなくなって、特定のwin10 sdkに依存するようになったわけではないです。
README.md
Outdated
| - C++に関するWindows XP サポート | ||
| - Windows 8.1 SDK と UCRT SDK | ||
| - C++ に関する Windows XP サポート | ||
| - x86用とx64用のVisual C++ MFC |
There was a problem hiding this comment.
8.1 sdkは現状で必須です。
これはいずれ修正しなければと考えていました。
MFCについては現状で不要です。
追加する必要はない認識です。
build.md
Outdated
| @@ -32,6 +32,9 @@ | |||
| - (オプション) [7Zip](https://sevenzip.osdn.jp/) (外部依存ファイルの解凍に使用) | |||
| - Visual Studio 2017 Comminity Edition | |||
| 以下オプションも必要です。 | |||
| - Windows 10 SDK (10.0.17134.0) | |||
There was a problem hiding this comment.
上にあげた理由で不要です。
サクラエディタはwindows sdkに依存します。
Win10 sdkについてはデフォルトを使いたいので、特定バージョンをいれたくないです。
|
修正しておきました。こんな感じでしょうか。 |
berryzplus
approved these changes
Oct 5, 2018
|
Merge します。もし問題が見つかったら別のPRで修正する事にしましょう。 |
Closed
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
Visual Studio Install options を修正(sakura-editor#6 の反映など)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
サクラエディタをビルドしてみようと Visual Studio Community 2017 をクリーンインストールしてみたところ、いくつか追加で必要だったので README.md を修正してみました。