Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Help でビルド方法に関する説明で build.md を参照するように変更 #606

Merged
merged 1 commit into from
Nov 10, 2018
Merged

HTML Help でビルド方法に関する説明で build.md を参照するように変更 #606

merged 1 commit into from
Nov 10, 2018

Conversation

m-tmatma
Copy link
Member

@m-tmatma m-tmatma commented Nov 9, 2018 •
edited
Loading

HTML Help でビルド方法に関する説明で build.md を参照するように変更

@m-tmatma m-tmatma added the document ドキュメント label Nov 9, 2018
@m-tmatma m-tmatma added this to the next release milestone Nov 9, 2018
@m-tmatma m-tmatma mentioned this pull request Nov 9, 2018
Merged
@m-tmatma m-tmatma changed the title HTML Help でビルド方法に関する説明を build.md を参照するように変更 HTML Help でビルド方法に関する説明で build.md を参照するように変更 Nov 9, 2018
berryzplus
berryzplus approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。
この変更により、「HTMLヘルプ独自のビルド方法説明」が消えて、ビルド方法は build.md に一元化されることになるのかな。

@m-tmatma m-tmatma merged commit 0056ca5 into sakura-editor:master Nov 10, 2018
@m-tmatma m-tmatma deleted the feature/fix-build-requirement-in-help2 branch November 10, 2018 09:02
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@m-tmatma
Merge pull request sakura-editor#606 from m-tmatma/feature/fix-build-…
da3fb3c 
…requirement-in-help2

HTML Help でビルド方法に関する説明で build.md を参照するように変更
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
document ドキュメント
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@m-tmatma @berryzplus