Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how Decorator Typing Works #111

Closed
3 tasks done
etsuo opened this issue Dec 30, 2017 · 0 comments
Closed
3 tasks done

Update how Decorator Typing Works #111

etsuo opened this issue Dec 30, 2017 · 0 comments
Assignees
Milestone

Comments

@etsuo
Copy link
Member

etsuo commented Dec 30, 2017

For example: SakuraApiModel and SakuraApiRoutable. Currently, SakuraApi is using abstract classes to define the static and prototype methods that are added to a class through injection via decorators like @Model and @Routable.

There are all kinds of problems with this:

More recently, this has become a problem with upgrading to TypeScript 2.6 -- there appear to be stricter checks in place that's leading to some unit tests failing because of TypeScript typing errors.

Goal:

  • Explore possible mixin / abstract class alternatives
  • Implement those alternatives
  • Update all the npm dependencies

Note: This means that v0.8.0 will be a breaking update.

Done - except for:

npm outdated
Package         Current  Wanted  Latest  Location
@types/jasmine   2.5.45  2.5.45   2.8.3  @sakuraapi/api
mongodb          2.2.33  2.2.33   3.0.1  @sakuraapi/api

The Jasmine typedef has issues... Mongo upgrade is being tracked by #112

@etsuo etsuo added this to the 0.8.0 milestone Dec 30, 2017
@etsuo etsuo self-assigned this Dec 30, 2017
@etsuo etsuo changed the title Update dependencies Update how Decorator Typing Works Dec 30, 2017
etsuo added a commit that referenced this issue Dec 30, 2017
@etsuo etsuo closed this as completed Dec 30, 2017
@etsuo etsuo removed the in progress label Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant