Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check color usage #131

Closed
tiiavalt opened this issue Mar 3, 2021 · 1 comment · Fixed by #132 or #144
Closed

Check color usage #131

tiiavalt opened this issue Mar 3, 2021 · 1 comment · Fixed by #132 or #144
Assignees
@tiiavalt
Labels
enhancement New feature or request

Comments

@tiiavalt
Copy link
Contributor

tiiavalt commented Mar 3, 2021

Is your feature request related to a problem? Please describe.
There are currently colors in the codebase that are not in Epimetheus' color palette.

Describe the solution you'd like
Incorrect colors should be replaced with Epimetheus' own colors.

Additional context
Let's also check that all the Epimetheus' color palette's colors are added as variables.
@tiiavalt tiiavalt added the enhancement New feature or request label Mar 3, 2021
@tiiavalt tiiavalt self-assigned this Mar 3, 2021
tiiavalt added a commit that referenced this issue Mar 4, 2021
@tiiavalt
#131 - Organize colors by the color palette
21a6060
tiiavalt added a commit that referenced this issue Mar 4, 2021
@tiiavalt
#131 - Add new 'evidence-grey-lighter' and correct 'hermanni-grey' an…
990275c 
…d 'titan-green-darker'.
tiiavalt added a commit that referenced this issue Mar 4, 2021
@tiiavalt
#131 - Fix to lowercase
133d4a5
tiiavalt added a commit that referenced this issue Mar 4, 2021
@tiiavalt
#131 - Replace hex colors with color variables
2415d40
tiiavalt added a commit that referenced this issue Mar 4, 2021
@tiiavalt
#131 - Replace 'theme' variables with other variables
8d47554
tiiavalt added a commit that referenced this issue Mar 4, 2021
@tiiavalt
#131 - Delete redundant theme and themeContext
cdc53df
tiiavalt added a commit that referenced this issue Mar 4, 2021
@tiiavalt
#131 - Fix few svg's fill color
8e404e6
tiiavalt added a commit that referenced this issue Mar 4, 2021
@tiiavalt
#131 - Unify DropdownSelect's focus style with the input's focus styles
fc1ae30
@tiiavalt tiiavalt linked a pull request Mar 4, 2021 that will close this issue
#131 - Check color usage #132
Merged
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - replace hex color with css variables in svgs
4d47f5c
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Organize colors by the color palette
3aa5e2b
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Add new 'evidence-grey-lighter' and correct 'hermanni-grey' an…
b715a50 
…d 'titan-green-darker'.
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Fix to lowercase
4401a14
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Replace hex colors with color variables
671e096
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Replace 'theme' variables with other variables
70998bb
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Delete redundant theme and themeContext
ae1e608
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Fix few svg's fill color
8224908
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Unify DropdownSelect's focus style with the input's focus styles
18bd1d0
tiiavalt added a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Replace hex color with css variables in svgs
e5b7e14
koops9 pushed a commit that referenced this issue Mar 5, 2021
@tiiavalt
#131 - Check color usage (#132)
67e8646 
* Organize colors by the color palette

* Add new 'evidence-grey-lighter' and correct 'hermanni-grey' and 'titan-green-darker'.

* Fix to lowercase

* Replace hex colors with color variables

* Replace 'theme' variables with other variables

* Delete redundant theme and themeContext

* Fix few svg's fill color

* Unify DropdownSelect's focus style with the input's focus styles

* Replace hex color with css variables in svgs
@koops9
Copy link
Contributor

koops9 commented Mar 5, 2021

Some svg imports seem to have lost their color so fixing that in future pull request...

tiiavalt added a commit that referenced this issue Mar 12, 2021
@tiiavalt
Revert "#131 - Replace hex color with css variables in svgs"
f56fbef 
This reverts commit e5b7e14.
@tiiavalt tiiavalt linked a pull request Mar 12, 2021 that will close this issue
Feature/131 - Revert "#131 - Replace hex color with css variables in svgs" #144
Merged
koops9 pushed a commit that referenced this issue Mar 12, 2021
@tiiavalt @koops9
Revert "#131 - Replace hex color with css variables in svgs"
13113a0 
This reverts commit e5b7e14.
@vade5g vade5g closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiiavalt tiiavalt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@vade5g @koops9 @tiiavalt