Fix missing restored rules #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rule`s "Rule Source Domain" which is the "hostName" filed is mandatory and should not be empty. |
|
I have the following rule to match all sites with prefix "192.168.88" i.e. sites within my LAN. Maybe I use it wrong?
|
|
Seems like a UI bug that field shows as required but allows empty source domain. I will need check this... |
salarcode
force-pushed
the
master
branch
6 times, most recently
from
ee4368c to
70c83cc
Compare
|
I have pushed a correct validation method that should fix this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, when restoring a full backup where there's no hostName in the rules, the restore will silently fail since it is deemed as an invalid rule. However, it is totally legit to have a hostName that is an empty string
"".This PR fixes the above issue so that we can import rules where hostName field is an empty string.