Release 2.3.2 #942
Closed
Release 2.3.2 #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOB 2859
- Move use-cases to separate files - Add interfaces for new added use-cases - Add interfaces for all Controllers - Upgrade mockk version - Convert GliaCore to kotlin - Fix minor bugs MOB 2958
- Remove unused Dialog `OnCancelListener`s MOB 2983
Paparazzi parameters were added to the base class constructor. Custom parameters for a single test are now available on the SnapshotTest.snapshot method. SnapshotTest.snapshotFullSize was removed. Instead, the SnapshotTest.fullWidthRenderMode was added. To test animations (like ProgressBar), animationRule was added. The SnapshotTest.dummyRule can be used to turn off this rule. The accuracy of screenshot difference detection is increased by decreasing maxPercentDifference. MOB-3001
Some VGA tests were refactored. The height for those views was calculated incorrectly. Instead of adding some fake data to this view to make them higher, the height was set manually. Now, the screenshots look better, and the tests do exactly what they need. MOB-3001
Now, class variables for mocks are unnecessary, and there is no need to call .setUp() and .tearDown() on them. The tests look simpler. MOB-3001
Reviewed all Kotlin classes and limited access to 'internal' if class/property are not supposed to be used by integrators or declared in Manifest. GR-553
Currently this class is public to integrators and is even used in out TestApp. GR-553
Currently this class is public to integrators and is even used in out TestApp. GR-553
…om integrators This classes are in Java, so to hide them I have to convert them to Kotlin and mark 'internal'. GR-553
There were two bugs: 1. The title text style is stuck if the new theme doesn't contain those changes. It is fixed by resetting the title appearance before applying the new confirmation screen theme; 2. If the previous text color was a gradient, the new single color doesn't apply. It is fixed by clearing the text paint shader. MOB-3016
OperatorStatusViewHolder was covered with screen tests. MOB-3021
Did this to prevent integrators accidentally using those classes because their name is very common in Android development. To make them internal had to also convert them to Kotlin GR-553
DavDo
requested changes
Feb 8, 2024
andrews-moc
reviewed
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging development branch into master