Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Engagement Ended dialog globally #1170

Open
wants to merge 1 commit into
base: feature/entry-widget-and-secure-conversations-v2
Choose a base branch
from
Open

Show Engagement Ended dialog globally #1170

wants to merge 1 commit into from

Conversation

EgorovEI
Copy link
Contributor

MOB-3905

What was solved?
This PR:

  • sets AlertPlacement for Engagement Ended dialog presenting;
  • removes handling of ended engagement on EngagementViewModel.viewWillApper.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Show Engagement Ended dialog globally
d1ad7fd 
This commit:
- sets `AlertPlacement` for Engagement Ended dialog presenting;
- removes handling of ended engagement on `EngagementViewModel.viewWillApper`.

MOB-3905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorkravchenko igorkravchenko Awaiting requested review from igorkravchenko

@rasmustautsglia rasmustautsglia Awaiting requested review from rasmustautsglia

@ykyivskyi-gl ykyivskyi-gl Awaiting requested review from ykyivskyi-gl

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EgorovEI