Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Dashboard crash on quick-menu escape #4166

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Fixes Dashboard crash on quick-menu escape #4166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c14afc7
crash-fix#3933
itsjainrishi Sep 4, 2023
46a635f
Merge branch 'saleor:main' into fix_quickmenu-escape_dashboard-crash
itsjainrishi Sep 6, 2023
f4832fe
Update changesets based deployments
itsjainrishi Sep 6, 2023
5c0430b
Merge branch 'fix_quickmenu-escape_dashboard-crash' of https://github…
itsjainrishi Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-rivers-taste.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

fix dashboard-crash on quickmenu escape
2 changes: 1 addition & 1 deletion src/components/Navigator/Navigator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const Navigator: React.FC<NavigatorProps> = ({ visible, setVisibility }) => {
item ? item.label : ""
}
onSelect={(item: QuickSearchAction) => {
const shouldRemainVisible = item.onClick();
const shouldRemainVisible = item?.onClick();
if (!shouldRemainVisible) {
setVisibility(false);
}
Expand Down
Loading