Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific version instead of branch name #4225

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

andrzejewsky
Copy link
Member

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@andrzejewsky andrzejewsky requested a review from a team as a code owner September 22, 2023 07:58
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: 9a2cdc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to sandbox-deployment-payload September 22, 2023 07:59 Destroyed
@github-actions github-actions bot temporarily deployed to storybook sandbox-deployment-payload September 22, 2023 07:59 Destroyed
@andrzejewsky andrzejewsky requested review from a team, poulch and Droniu September 22, 2023 08:00
@github-actions github-actions bot temporarily deployed to sandbox-deployment-payload September 22, 2023 08:00 Destroyed
@github-actions github-actions bot temporarily deployed to storybook sandbox-deployment-payload September 22, 2023 08:00 Destroyed
Droniu
Droniu previously approved these changes Sep 22, 2023
poulch
poulch previously approved these changes Sep 22, 2023
.github/workflows/prepare-release.yml Outdated Show resolved Hide resolved
.github/workflows/prepare-release.yml Outdated Show resolved Hide resolved
@andrzejewsky andrzejewsky dismissed stale reviews from poulch and Droniu via ab23b0a September 22, 2023 13:05
@github-actions github-actions bot temporarily deployed to sandbox-deployment-payload September 22, 2023 13:05 Destroyed
@github-actions github-actions bot temporarily deployed to storybook sandbox-deployment-payload September 22, 2023 13:05 Destroyed
.github/workflows/prepare-release.yml Outdated Show resolved Hide resolved
.github/workflows/prepare-release.yml Outdated Show resolved Hide resolved
andrzejewsky and others added 2 commits September 25, 2023 11:49
Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>
Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to sandbox-deployment-payload September 25, 2023 09:49 Destroyed
@github-actions github-actions bot temporarily deployed to storybook sandbox-deployment-payload September 25, 2023 09:49 Destroyed
@github-actions github-actions bot temporarily deployed to sandbox-deployment-payload September 25, 2023 09:49 Destroyed
@andrzejewsky andrzejewsky merged commit 0bf2f82 into main Sep 25, 2023
11 of 13 checks passed
@andrzejewsky andrzejewsky deleted the sandbox-deployment-payload branch September 25, 2023 09:58
poulch pushed a commit that referenced this pull request Sep 25, 2023
* Use specific version instead of branch name

* Changesets

* Use jq

* Update .github/workflows/prepare-release.yml

Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>

* Update .github/workflows/prepare-release.yml

Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>

---------

Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>
poulch pushed a commit that referenced this pull request Sep 25, 2023
* Use specific version instead of branch name

* Changesets

* Use jq

* Update .github/workflows/prepare-release.yml

Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>

* Update .github/workflows/prepare-release.yml

Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>

---------

Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants