Migrate navigation tests to playwright #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ae97dab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
temporarily deployed
to
migrate-navigation-test-to-playwright
github-actions
bot
temporarily deployed
to
storybook migrate-navigation-test-to-playwright
github-actions
bot
temporarily deployed
to
migrate-navigation-test-to-playwright
github-actions
bot
temporarily deployed
to
storybook migrate-navigation-test-to-playwright
poulch
previously approved these changes
Oct 6, 2023
Droniu
previously approved these changes
Oct 9, 2023
| this.permissionGroupsButton = page.locator( | ||
| "[data-test-id*='permission-groups']", | ||
| ); | ||
| this.staffMembersButton = page.locator("[data-test-id*='staff members']"); |
There was a problem hiding this comment.
Suggested change
| this.staffMembersButton = page.locator("[data-test-id*='staff members']"); | |
| this.staffMembersButton = page.locator("[data-test-id*='staff-members']"); |
szczecha
previously approved these changes
Oct 9, 2023
wojteknowacki
dismissed stale reviews from szczecha, Droniu, and poulch
via
ddeb5c9
github-actions
bot
temporarily deployed
to
migrate-navigation-test-to-playwright
github-actions
bot
temporarily deployed
to
storybook migrate-navigation-test-to-playwright
karola312
reviewed
Oct 11, 2023
playwright/tests/auth.setup.ts
Outdated
Comment on lines
34
to
56
| setup("authenticate as user with discount permissions", async ({ page }) => { | ||
| const loginPage = new LoginPage(page); | ||
| await loginPage.setupLogin( | ||
| USER_PERMISSION.discount, | ||
| process.env.CYPRESS_PERMISSIONS_USERS_PASSWORD!, | ||
| ); | ||
| const homePage = new HomePage(page); | ||
| await expect(homePage.welcomeMessage).toContainText("Hello there,"); | ||
| // End of authentication steps. | ||
| await page.context().storageState({ path: discountPermissionsFile }); | ||
| }); | ||
|
|
||
| setup("authenticate as user with orders permissions", async ({ page }) => { | ||
| const loginPage = new LoginPage(page); | ||
| await loginPage.setupLogin( | ||
| USER_PERMISSION.order, | ||
| process.env.CYPRESS_PERMISSIONS_USERS_PASSWORD!, | ||
| ); | ||
| const homePage = new HomePage(page); | ||
| await expect(homePage.welcomeMessage).toContainText("Hello there,"); | ||
| // End of authentication steps. | ||
| await page.context().storageState({ path: ordersPermissionsFile }); | ||
| }); |
There was a problem hiding this comment.
This code is almost same for all setups, cant we create the function loginAndSetStorageState(esername, pastowrd, pathtostorageStateFile)
github-actions
bot
temporarily deployed
to
migrate-navigation-test-to-playwright
szczecha
approved these changes
Oct 11, 2023
poulch
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4274
Screenshots
Pull Request Checklist
data-test-idare added for new elementsTest environment config
API_URI=https://master.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=6