Playwright fixture for handling grid events #4502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7af9cb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
temporarily deployed
to
storybook pr-grid-fixture-pw
poulch
previously approved these changes
Nov 29, 2023
playwright/pages/basePage.ts
Outdated
Comment on lines
109
to
110
| await this.page.locator('[class="clip-region"]').waitFor({ state: "attached" }); | ||
| await this.page.locator('[class="clip-region"]').locator("textarea").fill(content); |
There was a problem hiding this comment.
Suggested change
| await this.page.locator('[class="clip-region"]').waitFor({ state: "attached" }); | |
| await this.page.locator('[class="clip-region"]').locator("textarea").fill(content); | |
| await this.page.locator(this.gridInput).waitFor({ state: "attached" }); | |
| await this.page.locator(this.gridInput).fill(content); |
| @@ -13,7 +15,7 @@ export class BasePage { | |||
| constructor(page: Page) { | |||
| this.page = page; | |||
| this.pageHeader = page.getByTestId("page-header"); | |||
| this.gridCanvas = page.locator('[data-testid="data-grid-canvas"]'); | |||
| this.gridCanvas = page.locator(`[data-testid="${DEFAULT_GRID_TEST_ID}"]`); | |||
| this.successBanner = page.locator(LOCATORS.successBanner); | |||
| this.errorBanner = page.locator(LOCATORS.errorBanner); | |||
| } | |||
There was a problem hiding this comment.
Suggested change
| } | |
| this.gridInput = this.page.locator('[class="clip-region"]').locator("textarea") | |
| } |
playwright/pages/basePage.ts
Outdated
| @@ -13,7 +15,7 @@ export class BasePage { | |||
| constructor(page: Page) { | |||
| this.page = page; | |||
| this.pageHeader = page.getByTestId("page-header"); | |||
| this.gridCanvas = page.locator('[data-testid="data-grid-canvas"]'); | |||
| this.gridCanvas = page.locator(`[data-testid="${DEFAULT_GRID_TEST_ID}"]`); | |||
There was a problem hiding this comment.
Suggested change
| this.gridCanvas = page.locator(`[data-testid="${DEFAULT_GRID_TEST_ID}"]`); | |
| this.gridCanvas = page.locator(`[data-testid="data-grid-canvas"]`); |
playwright/pages/basePage.ts
Outdated
| @@ -3,6 +3,8 @@ import { URL_LIST } from "@data/url"; | |||
| import type { Locator, Page } from "@playwright/test"; | |||
| import { expect } from "@playwright/test"; | |||
|
|
|||
| const DEFAULT_GRID_TEST_ID = "data-grid-canvas" | |||
|
|
|||
| export class BasePage { | |||
| readonly page: Page; | |||
| readonly pageHeader: Locator; | |||
There was a problem hiding this comment.
Suggested change
| readonly pageHeader: Locator; | |
| readonly pageHeader: Locator; | |
| readonly gridInput: Locator; |
playwright/pages/basePage.ts
Outdated
| @@ -3,6 +3,8 @@ import { URL_LIST } from "@data/url"; | |||
| import type { Locator, Page } from "@playwright/test"; | |||
| import { expect } from "@playwright/test"; | |||
|
|
|||
| const DEFAULT_GRID_TEST_ID = "data-grid-canvas" | |||
There was a problem hiding this comment.
Suggested change
| const DEFAULT_GRID_TEST_ID = "data-grid-canvas" |
wojteknowacki
approved these changes
Nov 30, 2023
poulch
pushed a commit
that referenced
this pull request
Dec 19, 2023
* Fixture for grid * Fixture for grid * Fixture for grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Pull Request Checklist
data-test-idare added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=2