Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate old notifications to the new ones #587

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Migrate old notifications to the new ones #587

merged 2 commits into from
Jul 6, 2020

Conversation

AlicjaSzu
Copy link
Contributor

@AlicjaSzu AlicjaSzu commented Jul 6, 2020 •
edited
Loading

I want to merge this change because...

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@AlicjaSzu AlicjaSzu self-assigned this Jul 6, 2020
@patrys
Copy link
Member

patrys commented Jul 6, 2020

Task linked: CU-60rv0k Migrate old notifications to the new ones

@krzysztofwolski
Copy link
Member

Please update changelog

dominik-zeglen
dominik-zeglen approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@dominik-zeglen dominik-zeglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AlicjaSzu AlicjaSzu merged commit 7aea316 into master Jul 6, 2020
@AlicjaSzu AlicjaSzu deleted the feature/migrate-notifications branch July 6, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orzechdev orzechdev orzechdev approved these changes

@dominik-zeglen dominik-zeglen dominik-zeglen approved these changes

@krzysztofwolski krzysztofwolski krzysztofwolski approved these changes

Assignees

@AlicjaSzu AlicjaSzu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlicjaSzu @patrys @krzysztofwolski @dominik-zeglen @orzechdev