Apps #599
Merged
Apps #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 9a48688 into ffe0545 - view on LGTM.com new alerts:
|
Codecov Report
|
|
@AlicjaSzu our docs will need update. Please contact @korycins for details. |
orzechdev
reviewed
Jul 16, 2020
dominik-zeglen
approved these changes
Jul 20, 2020
| @@ -4,28 +4,40 @@ schema { | |||
| } | |||
|
|
|||
| type AccountAddressCreate { | |||
| errors: [Error!]! @deprecated(reason: "Use typed errors with error codes. This field will be removed after 2020-07-31.") | |||
| errors: [Error!]! | |||
| @deprecated( | |||
There was a problem hiding this comment.
Oops looks like someone used prettier on this
| @@ -11,6 +11,7 @@ All notable, unreleased changes to this project will be documented in this file. | |||
| - Handle task failure and fix task duplication - #588 by @dominik-zeglen | |||
| - Move fragments to separate directory to avoid circular imports - #592 by @dominik-zeglen | |||
| - Add order invoices management - #570 by @orzechdev | |||
| - create Apps - #599 by @AlicjaSzu | |||
There was a problem hiding this comment.
How about this?
Suggested change
| - create Apps - #599 by @AlicjaSzu | |
| - Add support for apps - #599 by @AlicjaSzu |
| import { FormattedMessage, useIntl } from "react-intl"; | ||
| import ReactMarkdown from "react-markdown"; | ||
|
|
||
| import activateIcon from "../../../../assets/images/activate-icon.svg"; |
There was a problem hiding this comment.
There's an alias for this
Suggested change
| import activateIcon from "../../../../assets/images/activate-icon.svg"; | |
| import activateIcon from "@assets/images/activate-icon.svg"; |
michalina-graczyk
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intended to be tested with API branch: feature/extending_app_support
Screenshots
Pull Request Checklist
Test environment config
API_URI=https://apps.staging.saleor.rocks/graphql/