Use hooks instead of containers with render props in product mutations #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orzechdev
approved these changes
Aug 25, 2020
AlicjaSzu
approved these changes
Aug 25, 2020
src/products/views/ProductCreate.tsx
Outdated
| })} | ||
| /> | ||
| <ProductCreatePage | ||
| currency={maybe(() => shop.defaultCurrency)} |
There was a problem hiding this comment.
More like shop?.defaultCurrency, but yeah
| if (variant) { | ||
| if ( | ||
| variant.images && | ||
| variant.images.map(image => image.id).indexOf(id) !== -1 |
There was a problem hiding this comment.
Didn't touch this, but I'll fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it simplifies code and removes obsolete pattern. Also makes life easier when you want to type return functions as
() => Promiseinstead of() => void.PR intended to be tested with API branch: master
Pull Request Checklist
Test environment config
API_URI=https://master.staging.saleor.rocks/graphql/