Add slug field to category, product, collection & page details #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add weight field and fix warehouse country selection
Fix weight based rate update
github-actions
bot
temporarily deployed
to
feat-add-slug-to-seo-form
github-actions
bot
had a problem deploying
to
storybook feat-add-slug-to-seo-form
bmigirl
changed the title
github-actions
bot
temporarily deployed
to
feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
storybook feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
storybook feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
storybook feat-add-slug-to-seo-form
dominik-zeglen
suggested changes
Sep 25, 2020
src/components/SeoForm/SeoForm.tsx
Outdated
| : getPageErrorMessage(error as PageErrorFragment, intl); | ||
| }; | ||
|
|
||
| const handleSlugChange = event => { |
There was a problem hiding this comment.
Untyped function argument
src/components/SeoForm/SeoForm.tsx
Outdated
| } | ||
| }; | ||
|
|
||
| const getError = fieldName => getFieldError(errors, fieldName); |
There was a problem hiding this comment.
Untyped function argument
| @@ -56,6 +56,7 @@ const PageDetailsPage: React.FC<PageDetailsPageProps> = ({ | |||
| }) => { | |||
| const intl = useIntl(); | |||
| const localizeDate = useDateLocalize(); | |||
| const pageExists = page === null; | |||
There was a problem hiding this comment.
pageExists is true if page doesn't exist
| "If empty, the preview shows what will be autogenerated." | ||
| })} | ||
| value={description ? description.slice(0, 299) : undefined} | ||
| helperText={intl.formatMessage(seoFieldMessage)} |
There was a problem hiding this comment.
If getError(SeoField.description) === true, this input will be red but won't display any message
There was a problem hiding this comment.
Ok, removing until we get errors for those fields from backend
src/components/SeoForm/SeoForm.tsx
Outdated
| loading?: boolean; | ||
| helperText?: string; | ||
| isCreating?: boolean; |
There was a problem hiding this comment.
I think the better name would be allowEmptySlug, it's more understandable from the component's perspective
github-actions
bot
temporarily deployed
to
feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
storybook feat-add-slug-to-seo-form
orzechdev
suggested changes
Sep 25, 2020
| @@ -56,6 +56,7 @@ const PageDetailsPage: React.FC<PageDetailsPageProps> = ({ | |||
| }) => { | |||
| const intl = useIntl(); | |||
| const localizeDate = useDateLocalize(); | |||
| const pageExists = page === null; | |||
There was a problem hiding this comment.
Suggested change
| const pageExists = page === null; | |
| const pageNotExists = page === null; |
github-actions
bot
temporarily deployed
to
feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
storybook feat-add-slug-to-seo-form
bmigirl
requested review from
dominik-zeglen,
orzechdev and
AlicjaSzu
and removed request for
AlicjaSzu
orzechdev
approved these changes
Sep 25, 2020
bmigirl
force-pushed
the
feat/add-slug-to-seo-form
branch
from
8330fc6
to
f956be3
Compare
github-actions
bot
temporarily deployed
to
feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
storybook feat-add-slug-to-seo-form
dominik-zeglen
approved these changes
Sep 25, 2020
github-actions
bot
temporarily deployed
to
feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
storybook feat-add-slug-to-seo-form
github-actions
bot
temporarily deployed
to
feat-add-slug-to-seo-form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SALEOR-1021
✨ After changes:
Pull Request Checklist
Test environment config
API_URI=https://master.staging.saleor.rocks/graphql/