Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Fix crash on null price range #875

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Fix crash on null price range #875

merged 2 commits into from
Aug 26, 2020

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Aug 25, 2020

I want to merge this change because... it fixes storefront crashes when the price range is null.

Screenshots

image
where index.tsx was referenced to
image

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to fix-null-pricing August 25, 2020 11:46 Inactive
@orzechdev orzechdev changed the title Fix null price range error Fix crash on null price range Aug 25, 2020
@patrys
Copy link
Member

patrys commented Aug 25, 2020

@github-actions github-actions bot temporarily deployed to fix-null-pricing August 25, 2020 11:49 Inactive
@orzechdev orzechdev marked this pull request as ready for review August 25, 2020 11:56
@github-actions github-actions bot temporarily deployed to fix-null-pricing August 26, 2020 09:37 Inactive
@orzechdev orzechdev merged commit 9464916 into master Aug 26, 2020
@orzechdev orzechdev deleted the fix/null-pricing branch August 26, 2020 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants