This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrgrundas
force-pushed
the
import-sort
branch
from
January 11, 2021 18:57
554ffa2
to
3234c1e
Compare
jwm0
reviewed
Jan 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
piotrgrundas
force-pushed
the
import-sort
branch
2 times, most recently
from
January 12, 2021 20:10
35a5057
to
e73ed8c
Compare
Can we merge it after nextjs merges with master? Would like to avoid situation, where all 256 files have shuffled imports and commit message is "add next js" (we are squashing PRs) |
@krzysztofwolski That's the plan 😄 |
piotrgrundas
force-pushed
the
import-sort
branch
from
January 13, 2021 17:38
76d8c7f
to
9579459
Compare
@jwm0 U mentioned u created some ticket for this? Could you link it with the ticket, please? 🙏 |
jwm0
approved these changes
Jan 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
eslint-plugin-simple-import-sort
Screenshots
Pull Request Checklist
Test Environment Config
API_URI=https://master.staging.saleor.rocks/graphql/