Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Listener for Configurable Alert Timeout #573

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cvillarongace
Copy link

Description

This PR introduces a new feature to dynamically update the alert timeout based on configuration changes. The feature enhances the reactivity of the MessageService by subscribing to changes in the configuration observable stream, specifically monitoring the alert_timeout property in the UI configuration.

Motivation and Context

The motivation for this change stems from a timing issue where the configuration was being loaded before the user-defined settings were properly applied. This resulted in the alert_timeout value defaulting to 3 seconds, regardless of the value specified in extensions or user settings. By introducing a listener for configuration changes, this update ensures that the alert timeout dynamically reflects the correct value as configured by the user, improving alignment between the application behavior and user expectations.

Benefits:

  • Dynamic Updates: Alert timeout adjusts automatically based on configuration changes.
  • Improved UX: Allows for more flexible and responsive user interface customization.
  • Efficiency: Avoids unnecessary updates using distinctUntilChanged.

Notes:

-This change is backward-compatible. If no alert_timeout is specified, the default value remains intact.
-Documentation for this enhancement has been included in the method comments.

How To Test This

  • Verified that MessageService reacts to changes in SystemConfigStore.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • [ x] My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • [ x] I have read the How to Contribute guidelines.

@SuiteBot
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Carlos Villaronga seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@desarrollador20 desarrollador20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code works correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants