Feature - Add ACL Access Logic Hooks #9846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralise duplicate logic into Sugarbean and update usages to use new function `buildAccessWhere` instead of all doing get owner and group call independently making it hard to extend
`before_acl_check` override and extend acl access checks `before_acl_query` override and extend acl access query where conditions
jack7anderson7
approved these changes
Dec 15, 2022
clemente-raposo
approved these changes
Dec 15, 2022
johnM2401
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add 2 new Logic Hooks:-
That allow you to extend and override access rights. To achieve this there was slight extension to the logic hook logic to allow it too return a value which was require in both cases, along side the general use of access logic being simplified through the CRM so it consistent and easily extendable via the new hooks.
The change should fully backward compatible and documentation to follow
Types of changes
Final checklist