Updates to 401 Handling #64
Conversation
| options.headers.Authorization = options.headers.Authorization || 'Bearer ' + authResponse.accessToken; | ||
|
|
||
| if(options.headers.Authorization) { | ||
| retry = false; |
There was a problem hiding this comment.
Missing options.headers.Authorization = options.headers.Authorization in this block.
There was a problem hiding this comment.
Actually, nevermind, just realized how dumb that would be.
There was a problem hiding this comment.
Based on that new realization, we should probably just var retry = false at the top, and these two blocks can just become one:
if(!options.headers.Authorization) {
options.headers.Authorization = 'Bearer ' + authResponse.accessToken;
retry = options.retry || false;
}
|
Seems good to me. @vernak2539 ? |
|
|
||
| if(!options.headers.Authorization) { | ||
| options.headers.Authorization = 'Bearer ' + authResponse.accessToken; | ||
| retry = options.retry || false; |
There was a problem hiding this comment.
So only retry if they don't provide custom auth headers?
There was a problem hiding this comment.
correct, thoughts?
There was a problem hiding this comment.
At first I wondered, but now I think it's fine. Since the auth header shouldn't really diff from the one provided (just there for an extra option), this is totally cool. 👍
|
So yeah, good to go @dougwilson if you want to publish. I'll be pto for a till next week. |
No description provided.