Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add undeclared dependency lodash #25

Merged

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Jul 17, 2021

What's the problem this PR addresses?

query-ast depends on lodash but doesn't declare it as a dependency

How did you fix it?

Added lodash as a dependency

@jcreamer898
Copy link

Same here. Haha. Need this fixed.

@iclanton
Copy link

iclanton commented Dec 8, 2022

@alexiscordova, @fredboyle, and @zahnster were recent contributors to this repository. Can one of you look at this issue?

@alexiscordova
Copy link
Contributor

@iclanton none of the folks you listed work at Salesforce anymore. @Dottenpixel might be your best bet

@Dottenpixel
Copy link
Contributor

Cheers @alexiscordova!

@merceyz, thank you for your contribution. We usually have a bot that prompts contributors to sign a contributor's licensing agreement (CLA) before accepting their PRs. I've just enabled the bot on this repo.

We can make the change internally, or if you'd like recreate this PR and sign the CLA when prompted by the bot.

@Dottenpixel Dottenpixel closed this Dec 8, 2022
@merceyz
Copy link
Contributor Author

merceyz commented Dec 9, 2022

I've already signed the CLA, ref salesforce-ux/scss-parser#43 (comment).

@Dottenpixel
Copy link
Contributor

I've already signed the CLA, ref salesforce-ux/scss-parser#43 (comment).

Right on, reopening the PR and merging. Thanks again @merceyz!

@Dottenpixel Dottenpixel self-requested a review December 12, 2022 05:44
@Dottenpixel Dottenpixel merged commit b228b06 into salesforce-ux:master Dec 12, 2022
@merceyz merceyz deleted the merceyz/fix/missing-lodash branch December 12, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants