Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): update nx to 9.4.0 #447

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

xbaun
Copy link
Contributor

@xbaun xbaun commented Jun 14, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the new behavior?

Update nx to 9.4.0 to fix nodejs/node#32852 when building akita with node v12/v13.

Does this PR introduce a breaking change?

  • Yes
  • No

@NetanelBasal NetanelBasal merged commit e75ef62 into salesforce:master Jun 15, 2020
@NetanelBasal
Copy link
Collaborator

@xbaun
Copy link
Contributor Author

xbaun commented Jun 15, 2020

Probably the problem is that node_modules is cached: https://github.com/datorama/akita/runs/771322765?check_suite_focus=true#step:4:8

@NetanelBasal
Copy link
Collaborator

But it should invalidate it when yarn.lock changes.

@xbaun
Copy link
Contributor Author

xbaun commented Jun 15, 2020

It's just a guess by me, because the build action ran on my branch without any errors and nx is using the node_modules/.cache folder for caching build targets. In the action log it looks like the cache is not invalidated.

@NetanelBasal
Copy link
Collaborator

Let's remove the cache and see if it works.

@NetanelBasal
Copy link
Collaborator

Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors from conditional exports after upgraded to Node 13.13
2 participants