Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

add http proxy support for ~node@v0.11.x #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zincli
Copy link

@zincli zincli commented Mar 5, 2015

fixed #7

internal method changed

http.Agent#addRequest(req, host, port, localAddress)  -->  http.Agent#addRequest(req, options)

@mattiash
Copy link

mattiash commented Apr 9, 2015

I have been running with this patch on both node 0.12.0 and 0.10.33 through an http proxy and it works perfectly. Without this patch, node 0.12.0 failed.

@fenwick67
Copy link

@stash Can we get this merged?

@stash-sfdc
Copy link
Contributor

I don't think it actually works with node 0.12 or the new 4.0 implementation. I've been working on a better solution, but I have not had time to finish it yet. Sorry, but can't promise an ETA just yet.

@christian-bromann
Copy link

@stash-sfdc it's working great for me too with node v5.1.0, looking forward to your change though. Thanks @zincli anyway. 👍

@stash-sfdc
Copy link
Contributor

@christian-bromann well that's some unexpected good news! what's your use-case of global-tunnel?

@christian-bromann
Copy link

@stash-sfdc proxying protractor requests through a transparent proxy

@stash-sfdc
Copy link
Contributor

@christian-bromann thanks for the response, but I think I asked that question the wrong way. Which one of these variations are you using to configure global-tunnel?

@christian-bromann
Copy link

the auto-config one:

var globalTunnel = require('global-tunnel');
process.env.http_proxy = process.env.HTTP_PROXY;
globalTunnel.initialize();

Would be nice if global-tunnel wouldn't care about capitalization though

@matttrawicki
Copy link

To make Node LTS 4.2.x work, all I needed to do was update tunnel to 0.0.4. My corporate proxy is https over http and I'm using auto-config via env like @christian-bromann . zincli@97910e7 was not needed for my use case, it works with or without those changes. I can submit a PR to bump the dependency version, let me know. Thanks!

wzrdtales added a commit to np-maintain/global-tunnel that referenced this pull request Aug 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with Node version 0.12.0
6 participants