-
Notifications
You must be signed in to change notification settings - Fork 48
add http proxy support for ~node@v0.11.x #9
base: master
Are you sure you want to change the base?
Conversation
I have been running with this patch on both node 0.12.0 and 0.10.33 through an http proxy and it works perfectly. Without this patch, node 0.12.0 failed. |
@stash Can we get this merged? |
I don't think it actually works with node 0.12 or the new 4.0 implementation. I've been working on a better solution, but I have not had time to finish it yet. Sorry, but can't promise an ETA just yet. |
@stash-sfdc it's working great for me too with node |
@christian-bromann well that's some unexpected good news! what's your use-case of global-tunnel? |
@stash-sfdc proxying protractor requests through a transparent proxy |
@christian-bromann thanks for the response, but I think I asked that question the wrong way. Which one of these variations are you using to configure |
the auto-config one: var globalTunnel = require('global-tunnel');
process.env.http_proxy = process.env.HTTP_PROXY;
globalTunnel.initialize(); Would be nice if |
To make Node LTS 4.2.x work, all I needed to do was update tunnel to 0.0.4. My corporate proxy is https over http and I'm using auto-config via env like @christian-bromann . zincli@97910e7 was not needed for my use case, it works with or without those changes. I can submit a PR to bump the dependency version, let me know. Thanks! |
Restore @zincil as origin author, see salesforce/global-tunnel#9
fixed #7
internal method changed