fix: aria props should be configurable/enumerable (#211)

salesforce · Aug 22, 2023 · 3623be1 · 3623be1
1 parent ea542a5
commit 3623be1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/@lwc/jest-preset/src/aria-reflection-polyfill.js b/packages/@lwc/jest-preset/src/aria-reflection-polyfill.js
@@ -67,6 +67,10 @@ for (const prop of ARIA_STRING_PROPS) {
                     this.setAttribute(attribute, value);
                 }
             },
+            // These props in both WebKit and Chromium are configurable/enumerable. This allows overriding
+            // (Try `Object.getOwnPropertyDescriptor(Element.prototype, 'ariaLabel')` in either browser)
+            configurable: true,
+            enumerable: true,
         });
     }
 }
diff --git a/test/src/modules/smoke/aria/__tests__/aria.spec.js b/test/src/modules/smoke/aria/__tests__/aria.spec.js
@@ -58,5 +58,11 @@ describe('ARIA string reflection', () => {
             div[prop] = null;
             expect(div.getAttribute(attribute)).toBeNull();
         });
+
+        it(`${prop} is configurable/enumerable`, () => {
+            const descriptor = Object.getOwnPropertyDescriptor(Element.prototype, prop);
+            expect(descriptor.configurable).toBe(true);
+            expect(descriptor.enumerable).toBe(true);
+        });
     }
 });