fix: add @lwc/engine as peerDependency of @lwc/jest-preset #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodarove
requested review from
ekashida,
pmdartus,
ravijayaramappa and
trevor-bliss
trevor-bliss
approved these changes
Jan 22, 2021
ekashida
reviewed
Jan 22, 2021
Comment on lines
24
to
26
| "@lwc/compiler": "*", | ||
| "@lwc/engine": "*", | ||
| "@lwc/synthetic-shadow": "*", |
There was a problem hiding this comment.
Should we specify lwc here instead of individual @lwc/* packages? We tell users to add lwc as a dependency instead of individual @lwc/* packages in their projects, but these users see installation warnings when they install our lwc-test packages because our lwc-test packages list out @lwc/* packages as peer dependencies.
Suggested change
| "@lwc/compiler": "*", | |
| "@lwc/engine": "*", | |
| "@lwc/synthetic-shadow": "*", | |
| "lwc": "*", |
|
@jodarove Please close the loop on this PR. |
pmdartus
approved these changes
Mar 25, 2021
|
Should we hold off on making this change until after we deprecate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lwc/engineis not marked as a peer dependency of@lwc/jest-preset. However,@lwc/engineis required during the environment setup.