fix: minimal ARIA string reflection polyfill for JSDOM #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Aug 15, 2023
|
|
||
| div[prop] = null; | ||
| expect(div.getAttribute(attribute)).toBeNull(); | ||
| }); |
There was a problem hiding this comment.
This is actually testing the polyfill, since the polyfill loads before @lwc/engine-dom.
This was referenced Aug 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's clear to me from Jest tests running in core that a lot of folks took a dependency on LWC's ARIA polyfill, at least for basic string reflection such as
role/ariaLabel/ariaExpanded/etc. Unfortunately it's not supported in JSDOM yet (jsdom/jsdom#3323), which makes it hard to drop the polyfill from LWC OSS (salesforce/lwc#3666).I propose that we put a minimal ARIA polyfill into
@lwc/jest-preset, implementing only the standard supported in Chrome/Safari. Reason being:jest-environment-jsdomis using jsdom v20, which is 2 major versions behind (latest is v22)This allows us to at least get the global polyfill out of the core LWC OSS repo, without needlessly breaking a bunch of Jest tests.