-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-16676971: drop support for Jest v.26 and v.27 #300
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,11 +168,6 @@ module.exports = { | |
// type getCacheKey = (sourceText: string, sourcePath: string, options: { configString: string }) => string; | ||
transformConfig = rest[0]; | ||
configString = transformConfig.configString; | ||
} else if (rest.length === 2) { | ||
// Handle jest@26 arguments | ||
// type getCacheKey = (sourceText: string, sourcePath: string, configStr: string, options: any) => string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like the whole There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is some comment regarding v.27 https://github.com/salesforce/lwc-test/pull/300/files#diff-f1a17bcd2dc683c79265f4962796d0f56d3b8c8771968b2256ae6483daad547bR167. Do I need just to remove it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I missed this. The comment is harmless but yes I guess it is redundant now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll remove it . |
||
configString = rest[0]; | ||
transformConfig = rest[1]; | ||
} else { | ||
throw new Error('Unexpected transform arguments.'); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition below is no longer needed since jest 28/29 is now implied (if the jest version is not "local"):