Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: address security advisory CVE-2020-7598 #1804

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

ekashida
Copy link
Member

@ekashida ekashida commented Apr 6, 2020

Details

GHSA-vh95-rmgr-6w4m

We can remove the yarn resolution for minimist when karma releases their next version which replaces the deprecated optimist package for yargs (karma-runner/karma#3451).

Uninstalled and reinstalled the following packages to update the lock file to pull in minimist@1.2.5:

  • @commitlint/cli
  • eslint
  • lerna
  • cssnano-preset-default
  • istanbul-api
  • karma
  • karma-coverage
  • @wdio/mocha-framework
  • @wdio/selenium-standalone-service
  • @best/cli
  • @best/runner-headless
  • @best/runner-remote

Does this PR introduce breaking changes?

  • No, it does not introduce breaking changes.

GUS work item

W-7391508

Copy link
Collaborator

@apapko apapko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we track the removal of minimist as a gus trust user story so that we don't forget to remove it?

@ekashida
Copy link
Member Author

ekashida commented Apr 6, 2020

@apapko #1805

@ekashida ekashida merged commit 39cd921 into master Apr 6, 2020
@ekashida ekashida deleted the ekashida/security-fix branch April 6, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants