chore: update babel deps #3573
Merged
chore: update babel deps #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jun 13, 2023
| @@ -9,6 +9,9 @@ import * as babel from '@babel/core'; | |||
| import babelClassPropertiesPlugin from '@babel/plugin-proposal-class-properties'; | |||
| import babelObjectRestSpreadPlugin from '@babel/plugin-proposal-object-rest-spread'; | |||
| import lwcClassTransformPlugin from '@lwc/babel-plugin-component'; | |||
| import lockerBabelPluginTransformUnforgeables from '@locker/babel-plugin-transform-unforgeables'; | |||
| import babelAsyncToGenPlugin from '@babel/plugin-transform-async-to-generator'; | |||
| import babelAsyncGeneratorFunctionsPlugin from '@babel/plugin-proposal-async-generator-functions'; | |||
There was a problem hiding this comment.
For whatever reason, Jest no longer likes us using the string format for Babel plugins – it fails to import it. So we can just import it directly instead.
nolanlawson
commented
Jun 13, 2023
| declare module '@babel/plugin-proposal-async-generator-functions' { | ||
| const props: any; | ||
| export = props; | ||
| } |
There was a problem hiding this comment.
None of these Babel plugins are typed; we already have a bunch of .d.ts files like these in the same directory
ekashida
approved these changes
Jun 14, 2023
|
/nucleus ignore --reason 'lwc-platform needs an update' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?