feat(template-compiler): enable quoted attribute expressions #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
approved these changes
Sep 10, 2024
| @@ -109,6 +111,10 @@ export const enum APIFeature { | |||
| * If enabled, add support for complex class expressions in the template. | |||
| */ | |||
| TEMPLATE_CLASS_NAME_OBJECT_BINDING, | |||
There was a problem hiding this comment.
Just noticed that this isn't ENABLE_ like the rest. Oh well, too late! 🫠
There was a problem hiding this comment.
It's not too late; we can change this...
nolanlawson
requested changes
Sep 10, 2024
| "start": 22, | ||
| "length": 17 | ||
| } | ||
| }, | ||
| { | ||
| "code": 1035, | ||
| "message": "LWC1035: Ambiguous attribute value title={myValue}checked. If you want to make it a string you should escape it title=\"\\{myValue}checked\"", |
There was a problem hiding this comment.
This error message is not super helpful anymore; it should probably say "go bump your API version" or something... Although I guess that's for later.
| if ( | ||
| isQuoted && | ||
| !isAPIFeatureEnabled(APIFeature.ENABLE_COMPLEX_TEMPLATE_EXPRESSIONS, ctx.apiVersion) | ||
| ) { |
There was a problem hiding this comment.
I'm nervous even just putting this out behind API versioning. Technically it would be a breaking change for off-core consumers or internal consumers if we change it during the release.
I think we should put this behind a (temporary) compiler flag as well.
nolanlawson
approved these changes
Sep 12, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Introduction of API feature for
ENABLE_COMPLEX_TEMPLATE_EXPRESSIONSbehind v63. Still need to replace all usage ofexperimentalComplexExpressionsbut will be doing that incrementally.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-16348355