p4: Check if p4 object is a file and return early if it isn't

[EricAtORS]

I tried using p4-fusion on our code base and it was crashing due to associated jobs.

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @thejinx0r to sign the Salesforce.com Contributor License Agreement.

[twarit-waikar]

@EricAtORS Hello! Thank you for sending this PR.

I actually didn't know that p4 describe can return results where the depotFile key doesn't exist. Can you share some information on in what cases is the depotFile key empty?

Based on that we should be able to decide on if that kind of object is worth handling differently or if we can just ignore it.

[EricAtORS]

@twarit-waikar
I haven't had a chance to login to my linux box with the soruce code and the log files, but it's related to Perforce Jobs.

Essentially, we have our Perforce server integrated with Jira and FishEye.
When JIRA creates a new issue in our of projects, it triggers FishEye to generate an associated job. Then, we can tag our changelists with a job id and JIRA/FishEye will update the issue with the associated changelists that we can see from FishEye.

In our case, varList was information about that associated job and not any file in our changelist.

[EricAtORS]

Also, I'm having issues signing the cla.
I had sent an email to contactoss-cla@salesforce.com but I just noticed that the email bounced.

[twarit-waikar]

Thanks a lot for sending this PR! This was something we didn't realise that could happen.

[justinharringa]

Also, I'm having issues signing the cla. I had sent an email to contactoss-cla@salesforce.com but I just noticed that the email bounced.

hey there - have you clicked on the link? Could you help me understand what the issue was? For example, did you click the link? Did you get an error?

Thanks and hope all is well

[twarit-waikar]

Hey @EricAtORS, could you check again if you can sign the CLA?

[EricAtORS]

Hi @twarit-waikar
When I first signed it, I got an error. I don't quite remember what it was, but I think it was some generic error about something going wrong.
Now, when I try with both my accounts (this one and my personal one that signed the commit), I get this message:
"You already signed the CLA on 2022-03-04"

[twarit-waikar]

@EricAtORS That should be enough then, I will re-trigger the CLA check on this PR. If you may, you can see my suggestions above, most of them are stylistic differences however

[twarit-waikar]

CLA check is completed now. Would like to know if you can commit the suggested changes or if I have the permission to build on top of your changes so I can make those minor stylistic changes.

Thanks!

[EricAtORS]

@twarit-waikar
Thanks for updating the checks.

You are more than welcome to build on top of my changes to make the stylistic ones. I just haven't had access to my linux bot to do it. If you do it, it would be very appreciated from my part as I'm not sure when I will get access to my linux box.

[twarit-waikar]

Thanks for sending the PR!