-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Restore zstd-compressed database backup #273
Open
dlipovetsky
wants to merge
1
commit into
salesforce:master
Choose a base branch
from
dlipovetsky:restore-compressed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
package ingress | ||
|
||
import ( | ||
"fmt" | ||
"os" | ||
"path/filepath" | ||
"testing" | ||
"time" | ||
|
||
"github.com/golang/protobuf/ptypes/timestamp" | ||
"github.com/klauspost/compress/zstd" | ||
"github.com/pkg/errors" | ||
"github.com/salesforce/sloop/pkg/sloop/store/typed" | ||
"github.com/salesforce/sloop/pkg/sloop/store/untyped" | ||
"github.com/salesforce/sloop/pkg/sloop/store/untyped/badgerwrap" | ||
) | ||
|
||
func TestDatabaseRestore(t *testing.T) { | ||
tests := []struct { | ||
name string | ||
backupFn func(db badgerwrap.DB, path string) error | ||
wantErr error | ||
}{ | ||
{ | ||
name: "restore uncompressed database backup", | ||
backupFn: backupUncompressed, | ||
}, | ||
{ | ||
name: "restore zstd-compressed database backup", | ||
backupFn: backupZstdCompressed, | ||
}, | ||
} | ||
|
||
tmpDir, err := os.MkdirTemp("", "") | ||
if err != nil { | ||
t.Fatalf("failed to create temporary directory: %s", err) | ||
} | ||
|
||
for i, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
db, err := createExampleDatabase() | ||
if err != nil { | ||
t.Fatalf("failed to create example database: %s", err) | ||
} | ||
defer db.Close() | ||
|
||
dbPath := filepath.Join(tmpDir, fmt.Sprintf("test-%d.db", i)) | ||
err = tt.backupFn(db, dbPath) | ||
if err != nil { | ||
t.Fatalf("failed to backup example database: %s", err) | ||
} | ||
|
||
if err := DatabaseRestore(db, dbPath); err != tt.wantErr { | ||
t.Errorf("DatabaseRestore() error = %v, wantErr %v", err, tt.wantErr) | ||
} | ||
}) | ||
} | ||
} | ||
|
||
func backupUncompressed(db badgerwrap.DB, path string) error { | ||
w, err := os.Create(path) | ||
if err != nil { | ||
return errors.Wrapf(err, "failed to create file") | ||
} | ||
defer w.Close() | ||
|
||
_, err = db.Backup(w, 0) | ||
if err != nil { | ||
return errors.Wrapf(err, "failed to backup database") | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func backupZstdCompressed(db badgerwrap.DB, path string) error { | ||
cf, err := os.Create(path) | ||
if err != nil { | ||
return errors.Wrapf(err, "failed to create file") | ||
} | ||
defer cf.Close() | ||
|
||
zw, err := zstd.NewWriter(cf) | ||
if err != nil { | ||
return errors.Wrapf(err, "failed to create zstd writer") | ||
} | ||
|
||
_, err = db.Backup(zw, 0) | ||
if err != nil { | ||
return errors.Wrapf(err, "failed to backup database") | ||
} | ||
zw.Close() | ||
|
||
return nil | ||
} | ||
|
||
func createExampleDatabase() (badgerwrap.DB, error) { | ||
rootPath, err := os.MkdirTemp("", "") | ||
if err != nil { | ||
return nil, errors.Wrapf(err, "failed to create temporary directory for database:") | ||
} | ||
|
||
factory := &badgerwrap.BadgerFactory{} | ||
storeConfig := &untyped.Config{ | ||
RootPath: rootPath, | ||
ConfigPartitionDuration: time.Hour, | ||
} | ||
db, err := untyped.OpenStore(factory, storeConfig) | ||
if err != nil { | ||
return nil, errors.Wrapf(err, "failed to init untyped store:") | ||
} | ||
|
||
wt := typed.OpenKubeWatchResultTable() | ||
err = db.Update(func(txn badgerwrap.Txn) error { | ||
txerr := wt.Set(txn, | ||
typed.NewWatchTableKey( | ||
"somePartition", | ||
"someKind", | ||
"someNamespace", | ||
"someName", | ||
time.UnixMicro(0)).String(), | ||
&typed.KubeWatchResult{Timestamp: ×tamp.Timestamp{ | ||
Seconds: 0, | ||
Nanos: 0, | ||
}, Kind: "test", Payload: "test"}) | ||
if txerr != nil { | ||
return txerr | ||
} | ||
return nil | ||
}) | ||
if err != nil { | ||
return nil, errors.Wrapf(err, "error updating database:") | ||
} | ||
|
||
return db, nil | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to check if the file is compressed or not before loading the database, but could not find a way to do that using the zstd package. Attempting to load the database is the best alternative I found.