-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing slash breaks ESM compatibility #256
Comments
I think the slash isn't required; I'll take a look at our package.json. |
This change was introduced in #238 in order to enforce the use of the punycode npm package, rather than node's built-in. One possible resolution is to import the main export directly, |
9 tasks
colincasey
added a commit
that referenced
this issue
Feb 29, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally reported in sveltejs/kit#7085
Loading this library in a project that uses Node.js ESM without bundling does not work:
I believe the error is coming from this line:
tough-cookie/lib/cookie.js
Line 32 in d4ac580
Is there a reason to have that trailing slash or can it be removed?
The text was updated successfully, but these errors were encountered: