Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: distinguish between no samesite and samesite=none #240

Merged
merged 3 commits into from
Jul 27, 2022
Merged

fix: distinguish between no samesite and samesite=none #240

merged 3 commits into from
Jul 27, 2022

Conversation

colincasey
Copy link
Contributor

closes #191

@colincasey colincasey self-assigned this Jun 23, 2022
wjhsf
wjhsf reviewed Jun 23, 2022
View reviewed changes
lib/cookie.js Show resolved Hide resolved
lib/cookie.js Show resolved Hide resolved
@chrisbreiding chrisbreiding mentioned this pull request Jun 30, 2022
Merged
2 tasks
awaterma
awaterma approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a note for this p/r into the changelog for 4.1; we can do that in a separate p/r, but I think we may want to do it here so we don't miss the note on release.

@awaterma
Copy link
Member

@wjhsf -- anything holding us back here? Perhaps we can try and discuss in our meeting tomorrow?

@awaterma awaterma merged commit aa4396d into master Jul 27, 2022
@awaterma awaterma deleted the ccasey/fix_191_samesite_default branch July 27, 2022 17:53
adamjmcgrath added a commit to auth0/nextjs-auth0 that referenced this pull request Jun 14, 2023
@adamjmcgrath
This was a wrong test thrown off by salesforce/tough-cookie#240
ce406af
@Silverium Silverium mentioned this pull request Aug 26, 2023
Open
wjhsf pushed a commit that referenced this pull request Feb 8, 2024
@abdulsattar
fix: update @lwc/jest-* libraries to support Jest v27 (#240)
f2c9de2
@botanical botanical mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaterma awaterma awaterma approved these changes

@wjhsf wjhsf wjhsf approved these changes

Assignees

@colincasey colincasey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to distinguish between unspecified SameSite and SameSite=None
3 participants
@colincasey @awaterma @wjhsf