pr review feedback #448
Merged
pr review feedback #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
approved these changes
Jul 26, 2024
mshanemc
added a commit
that referenced
this pull request
Jul 26, 2024
* feat: no-depends-on-boolean-flag rule * test: fix UTs * test: skip ts-dep-check * test: fix workflow ref * chore: retry * test: back to main * test: tmp fail * Update no-depends-on-boolean-flag.md * chore: back to warn * chore: add link to doc * test: skipTsCheck bool=true * test: skipTsCheck bool=false * test: skipTsCheck bool=true * chore: back to main * pr review feedback (#448) * refactor: pr review * refactor: min/max/default * chore: update msg * chore: wrong doc --------- Co-authored-by: Shane McLaughlin <shane.mclaughlin@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found a way to narrow types and avoid the ts-ignore
curryied the
flagPropertyIsNamedfn and replace that everywhere it was used.and cleaned up a few other things unrelated to the pr