Use node 'current' in UT, allow disable #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
May 9, 2024
mshanemc
approved these changes
May 9, 2024
| @@ -18,6 +18,9 @@ runs: | |||
| shell: bash | |||
| id: node-versions | |||
| run: | | |||
| # Current can be disabled by setting the GHA var "UT_DISABLE_NODE_CURRENT" to "true" | |||
There was a problem hiding this comment.
I like that an org-level var could disable it.
mshanemc
added a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had disabled Node
currentin unit tests when we were having issues with Node 21. This brings it back along with the ability to disable it with an env var in Github Actions (either at the org or repo level).@W-15716084@