-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use hooks for list and display #121
Conversation
7339d47
to
d5dd6e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdonnalley just one suggestion to replace if/else with lambda
src/hooks/envList.ts
Outdated
for (const org of orgs) { | ||
if (org.isScratchOrg) { | ||
grouped.scratchOrgs = grouped.scratchOrgs.concat(org); | ||
} else { | ||
grouped.nonScratchOrgs = grouped.nonScratchOrgs.concat(org); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for (const org of orgs) { | |
if (org.isScratchOrg) { | |
grouped.scratchOrgs = grouped.scratchOrgs.concat(org); | |
} else { | |
grouped.nonScratchOrgs = grouped.nonScratchOrgs.concat(org); | |
} | |
} | |
[scratchOrgs, nonScratchOrgs] = orgs.reduce(([s,n], o) => o.isScratchOrg() ? [[...s, o], n] : [s, [...n, o]], [[],[]] | |
const grouped = { | |
nonScratchOrgs: nonScratchOrgs as OrgAuthorization[], | |
scratchOrgs: scratchOrgs as OrgAuthorization[], | |
}; |
Heya @mdonnalley I'm QA'ing this now and noticed |
This will be resolved by oclif/core#243 |
7253493
to
b7800fd
Compare
I'm still seeing the same delay after pulling and building the latest changes and running |
The delay at the end was only happening when using |
What does this PR do?
Uses new hook interface from sf-plugins-core for
env list
andenv display
Notable Changes:
--extended
flag fromenv list
since we agreed that json output and table output will always have the same informationWhat issues does this PR fix or reference?
@W-9811480@
@W-9769891@