test: update assertion to use regex for new DH (@W-11466097@) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jye-sf
approved these changes
Aug 31, 2022
test/commands/lwc/test/run.nut.ts
Outdated
| @@ -56,8 +56,8 @@ describe('lightning:lwc:test:run', () => { | |||
| const output = execCmd<RunResult>('force:lightning:lwc:test:run', { | |||
| ensureExitCode: 0, | |||
| }).shellOutput.stderr; | |||
| expect(output).to.include('Test Suites: 13 passed, 13 total'); | |||
| expect(output).to.include('Tests: 65 passed, 65 total'); | |||
| expect(output).to.match(/Test Suites:\s+\d+ passed,\s+\d+\s+total/); | |||
There was a problem hiding this comment.
nit: Why do we have \s+\d+ with a space here when all the rest have \s+\d+\s+ with no space?
nolanlawson
force-pushed
the
nolan/fix-regex
branch
2 times, most recently
from
a726279
to
f98b6ac
Compare
|
@jye-sf The |
nolanlawson
force-pushed
the
nolan/fix-regex
branch
from
f98b6ac
to
4e1e6bc
Compare
|
Ah wait, that's not it. It's just totally borked for some reason. I'll open a brand new PR to satisfy the CI gods. |
|
Hm, that doesn't work either: #54 |
nolanlawson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #52 (comment)
@W-11466097