Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add org open agent #1264

Merged
merged 5 commits into from
Nov 15, 2024
Merged

feat: add org open agent #1264

merged 5 commits into from
Nov 15, 2024

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Nov 12, 2024

What does this PR do?

Adds a new command (org open agent) to open an agent in the Agent Builder org UI by the developer (API) name. Refactors the org open command for better code reuse.

What issues does this PR fix or reference?

@W-17205614@

@shetzel shetzel requested a review from a team as a code owner November 12, 2024 01:06
private: boolean;
};

export abstract class OrgOpenCommandBase<T> extends SfCommand<T> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my preference is not use base command classes (it can have some surprising side-effects like loosing the value of the static enableJsonFlag prop).

Especially since there's only one method here that's being shared

@mdonnalley
Copy link
Contributor

QA

🟢 sf org open
🟢 sf org open --private
🟢 sf org open --browser firefox
🟢 sf org open --url-only --path lightning
🟢 sf org open --source-file force-app/main/default/flexipages/Hello.flexipage-meta.xml
🟢 sf org open --source-file force-app/main/default/flows/Hello.flow-meta.xml
🟢 sf org open --source-file force-app/main/default/bots/Coral_Cloud_Agent/Coral_Cloud_Agent.bot-meta.xml
🟢 sf org open agent --name Coral_Cloud_Agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants