Merge pull request #523 from salesforcecli/devScripts2024-03-24

refactor: devScripts update
salesforcecli · Mar 25, 2024 · fcb1215 · fcb1215
2 parents 8c89b2f + 1365325
commit fcb1215
Show file tree

Hide file tree

Showing 4 changed files with 230 additions and 261 deletions.
diff --git a/package.json b/package.json
@@ -53,7 +53,7 @@
   },
   "devDependencies": {
     "@inquirer/type": "^1.2.0",
-    "@salesforce/dev-scripts": "^8.4.0",
+    "@salesforce/dev-scripts": "^8.4.2",
     "eslint-plugin-sf-plugin": "^1.17.4",
     "ts-node": "^10.9.2",
     "typescript": "^5.4.3"

diff --git a/src/stubUx.ts b/src/stubUx.ts
@@ -6,6 +6,8 @@
  */
 /* eslint-disable @typescript-eslint/explicit-function-return-type */
 
+// intentionally keep sinon out of dependencies since this is meant for test-time only
+// eslint-disable-next-line import/no-extraneous-dependencies
 import { SinonSandbox } from 'sinon';
 import { SfCommand } from './sfCommand.js';
 import { Spinner } from './ux/spinner.js';

diff --git a/src/ux/prompts.ts b/src/ux/prompts.ts
@@ -7,7 +7,7 @@
 
 import { setTimeout } from 'node:timers/promises';
 import { SfError } from '@salesforce/core';
-import { CancelablePromise } from '@inquirer/type';
+import type { CancelablePromise } from '@inquirer/type';
 
 export type PromptInputs<T> = {
   /** text to display.  Do not include a question mark */