Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set defaultHelp on duration flag #514

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: set defaultHelp on duration flag #514

merged 1 commit into from
Mar 19, 2024

Conversation

mdonnalley
Copy link
Contributor

Set defaultHelp on duration flag so that we get a human readable string in the help output

@W-14625639@

@mdonnalley mdonnalley mentioned this pull request Mar 13, 2024
Merged
@shetzel
Copy link
Contributor

shetzel commented Mar 19, 2024

QA:
generated an oclif manifest with yarn oclif manifest and inspected oclif.manifest.json wait flag entries. All entries had a readable string of: "default": "0 minutes",

@shetzel shetzel merged commit e6e9322 into main Mar 19, 2024
44 checks passed
@shetzel shetzel deleted the mdonnalley/duration-default-help branch March 19, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdonnalley @shetzel