fixed bug for points

saleweaver · Feb 9, 2021 · 8cc123b · 8cc123b
1 parent a30e2d9
commit 8cc123b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/setup.py b/setup.py
@@ -2,7 +2,7 @@
 
 setup(
     name='python-amazon-sp-api',
-    version='0.2.2',
+    version='0.2.3',
     install_requires=[
         "requests",
         "six~=1.15.0",

diff --git a/sp_api/api/product_fees/product_fees.py b/sp_api/api/product_fees/product_fees.py
@@ -9,7 +9,7 @@ class ProductFees(Client):
 
     @sp_endpoint('/products/fees/v0/listings/{}/feesEstimate', method='POST')
     def get_product_fees_estimate_for_sku(self, seller_sku, price: float, shipping_price=None, currency='USD',
-                                          is_fba=False, points: dict = dict, **kwargs) -> ApiResponse:
+                                          is_fba=False, points: dict = None, **kwargs) -> ApiResponse:
         """
         get_product_fees_estimate_for_sku(self, seller_sku, price: float, shipping_price=None, currency='USD', is_fba=False, points: dict = dict, **kwargs) -> ApiResponse
 
@@ -33,7 +33,7 @@ def get_product_fees_estimate_for_sku(self, seller_sku, price: float, shipping_p
 
     @sp_endpoint('/products/fees/v0/items/{}/feesEstimate', method='POST')
     def get_product_fees_estimate_for_asin(self, asin, price: float, currency='USD', shipping_price=None, is_fba=False,
-                                           points: dict = dict,
+                                           points: dict = None,
                                            **kwargs) -> ApiResponse:
         """
         get_product_fees_estimate_for_asin(self, asin, price: float, currency='USD', shipping_price=None, is_fba=False,  points: dict = dict, **kwargs) -> ApiResponse
@@ -56,7 +56,7 @@ def get_product_fees_estimate_for_asin(self, asin, price: float, currency='USD',
         kwargs.update(self._create_body(price, shipping_price, currency, is_fba, asin, points))
         return self._request(fill_query_params(kwargs.pop('path'), asin), data=kwargs)
 
-    def _create_body(self, price, shipping_price=None, currency='USD', is_fba=False, identifier=None, points=dict):
+    def _create_body(self, price, shipping_price=None, currency='USD', is_fba=False, identifier=None, points: dict=None):
         """
         Create request body
 
@@ -83,7 +83,7 @@ def _create_body(self, price, shipping_price=None, currency='USD', is_fba=False,
                         'Amount': shipping_price,
                         'CurrencyCode': currency
                     } if shipping_price else None,
-                    **points
+                    'Points': points or None
                 },
                 'IsAmazonFulfilled': is_fba,
                 'MarketplaceId': self.marketplace_id

diff --git a/tests/api/product_fees/product_fees.py b/tests/api/product_fees/product_fees.py
@@ -6,23 +6,23 @@
 
 def test_get_fees_for_sku():
     res = ProductFees().get_product_fees_estimate_for_sku("UmaS1", 10, currency='USD', shipping_price=10, is_fba=False,
-                                                          points={"Points": {
+                                                          points={
                                                               "PointsNumber": 0,
                                                               "PointsMonetaryValue": {
                                                                   "CurrencyCode": "USD",
                                                                   "Amount": 0
                                                               }
-                                                          }})
+                                                          })
     assert res.payload.get('FeesEstimateResult').get('Status') == 'Success'
 
 
 def test_get_fees_for_asin():
     res = ProductFees().get_product_fees_estimate_for_asin("UmaS1", 10, currency='USD', shipping_price=10, is_fba=False,
-                                                           points={"Points": {
+                                                           points={
                                                                "PointsNumber": 0,
                                                                "PointsMonetaryValue": {
                                                                    "CurrencyCode": "USD",
                                                                    "Amount": 0
                                                                }
-                                                           }})
+                                                           })
     assert res.payload.get('FeesEstimateResult').get('Status') == 'Success'