Skip to content
This repository has been archived by the owner on Nov 10, 2019. It is now read-only.

Add method to return data for some years only #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

daniel08s
Copy link

Currently the API only gives the option of getting the information for all the years we've been registered.

When checking the chart for my contributions I noticed that I've had this account for a long time before really getting active, which causes the chart to be filled with 'blank' years.

I though about adding an option for an user to exclude certain years so I created this PR. Obviously, this would also require a change in the frontend project, but I haven't looked at it yet.

Let me know if you think this could be a valid thing, even if some changes are needed.

@sallar
Copy link
Owner

sallar commented May 4, 2018

Hi! This is a great idea. although the current function can be modified to have this. you could add a second argument to fetchYears function, so it filters out the blacklist before returning the values. what do you think?

@daniel08s
Copy link
Author

daniel08s commented May 4, 2018

Only noticed now that you mentioned the fetchYears function and not the one I changed. I'll fix it.

@cujarrett cujarrett mentioned this pull request Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants