Skip to content

Commit

Permalink
Update system_settings.py
Browse files Browse the repository at this point in the history
I figured since [Sal's 'Settings' wiki page](https://github.com/salopensource/sal/wiki/Settings) states the following...
```
There are defaults set in sal/system_settings.py, but they can be overridden if you choose
```
... that it might be a good idea to enumerate most every toggle-able feature within the `server_settings.py` file. That said... 

This PR suggests the following changes to `sal/sal/system_settings.py`:
- Add comment explanation (pulled from the wiki page) above `EXCLUDED_FACTS` definition
- Add `IGNORE_FACTS` setting with default value of `[]`
- Add `ADD_TO_ALL_BUSINESS_UNITS` with default value of `False`
- Add `ADD_NEW_MACHINES` with default value of `True`
  • Loading branch information
ChefAustin authored Jun 3, 2020
1 parent e3e3106 commit 794c5da
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions sal/system_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
DISPLAY_NAME = 'Sal'
MANAGERS = ADMINS
DEPLOYED_ON_CHECKIN = False
ADD_TO_ALL_BUSINESS_UNITS = False
ADD_NEW_MACHINES = True
INACTIVE_UNDEPLOYED = 0
SEARCH_FACTS = []
SEARCH_CONDITIONS = []
Expand Down Expand Up @@ -86,6 +88,10 @@
# How long to keep historical facts around before pruning them.
HISTORICAL_DAYS = 180

# Facts to be discarded and not saved to the database
IGNORE_FACTS = []

# Facts to not be displayed on the Machine Information page
EXCLUDED_FACTS = {
'sshrsakey',
'sshfp_rsa',
Expand Down

0 comments on commit 794c5da

Please sign in to comment.