fix: Update undeployed to work #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should filter using less than or equal to find dates in the past not greater than or equal which would be dates in the future. This also corrects the machine call to use `Machine` (no 's')
|
Me type good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should filter using less than or equal to find dates in the past not
greater than or equal which would be dates in the future.
This also corrects the machine call to use
Machine(no 's')I've tested this using the
INACTIVE_UNDEPLOYED = 90setting with a machine that had the checkin date modified in the database. After runningpython manage.py search_maintenancethe machine properly has it's object moved to the undeployed status.With
DEPLOYED_ON_CHECKIN = Trueenabled in the settings, I then had the machine checkin and Sal properly removed it from the undeployed status.cc: @erikng