Feature rework install log processing

api/fixtures/machine_fixtures.json

@@ -23,16 +23,13 @@
         "last_checkin": "2016-10-06T19:29:38.376Z",
         "first_checkin": "2016-10-06T15:51:21.145Z",
         "report": "",
-        "report_format": "base64bz2",
         "errors": 4,
         "warnings": 7,
-        "activity": "",
+        "activity": false,
         "puppet_version": "4.7.0",
         "sal_version": "1.0.6",
         "last_puppet_run": "2016-10-06T19:06:21Z",
         "puppet_errors": 0,
-        "install_log_hash": "ed168dbcf43e8c89ec3bc1a5708a7210cfeeedf0fc4e8cbbda2e0b50af782e72",
-        "install_log": "",
         "deployed": true,
         "broken_client": false
     }
@@ -61,16 +58,13 @@
         "last_checkin": "2017-05-16T19:04:51.336Z",
         "first_checkin": "2017-05-16T19:04:51.728Z",
         "report": "",
-        "report_format": "base64bz2",
         "errors": 0,
         "warnings": 3,
-        "activity": "",
+        "activity": false,
         "puppet_version": "4.10.1",
         "sal_version": "2.0.3",
         "last_puppet_run": "2017-05-16T18:54:56Z",
         "puppet_errors": 0,
-        "install_log_hash": null,
-        "install_log": null,
         "deployed": true,
         "broken_client": false
     }

api/fixtures/search_fixtures.json

@@ -56,7 +56,7 @@
     "fields": {
         "search_group": 3,
         "search_models": "Machine",
-        "search_field": "hostname",
+        "search_field": "serial",
         "and_or": "AND",
         "operator": "=",
         "search_term": "C0DEADBEEF",

api/v1/serializers.py

@@ -97,4 +97,4 @@ class MachineSerializer(serializers.ModelSerializer):
 
     class Meta:
         model = Machine
-        exclude = ('report', 'install_log', 'install_log_hash')
+        exclude = ('report', )

api/v2/serializers.py

@@ -106,7 +106,7 @@ class MachineSerializer(QueryFieldsMixin, serializers.ModelSerializer):
         'machine_model_friendly', 'memory', 'memory_kb', 'warnings',
         'first_checkin', 'last_checkin', 'hd_total', 'os_family', 'deployed',
         'operating_system', 'machine_group', 'sal_version', 'manifest',
-        'hd_percent', 'cpu_type', 'broken_client', 'report_format')
+        'hd_percent', 'cpu_type', 'broken_client', 'activity')
 
     class Meta:
         model = Machine

api/v2/tests/test_machines.py

@@ -9,15 +9,13 @@
 
 
 ALL_MACHINE_COLUMNS = {
-    'console_user', 'munki_version', 'hd_space', 'machine_model', 'cpu_speed',
-    'serial', 'id', 'last_puppet_run', 'errors', 'puppet_version', 'hostname',
-    'puppet_errors', 'machine_model_friendly', 'memory', 'memory_kb',
-    'warnings', 'install_log', 'first_checkin', 'last_checkin',
-    'broken_client', 'hd_total', 'os_family', 'report', 'deployed',
-    'operating_system', 'report_format', 'machine_group', 'sal_version',
-    'manifest', 'hd_percent', 'cpu_type', 'activity', 'install_log_hash'}
-REMOVED_MACHINE_COLUMNS = {
-    'activity', 'report', 'install_log', 'install_log_hash'}
+    'console_user', 'munki_version', 'hd_space', 'machine_model', 'cpu_speed', 'serial', 'id',
+    'last_puppet_run', 'errors', 'puppet_version', 'hostname', 'puppet_errors',
+    'machine_model_friendly', 'memory', 'memory_kb', 'warnings', 'first_checkin', 'last_checkin',
+    'broken_client', 'hd_total', 'os_family', 'report', 'deployed', 'operating_system',
+    'machine_group', 'sal_version', 'manifest', 'hd_percent', 'cpu_type',
+    'activity'}
+REMOVED_MACHINE_COLUMNS = {'report'}
 
 
 class MachinesTest(SalAPITestCase):
@@ -93,15 +91,13 @@ def test_detail_include_fields(self):
         """Test the field inclusion/exclusion params for detail."""
         response = self.authed_get(
             'machine-detail', args=('C0DEADBEEF',),
-            params={'fields': 'activity', 'fields!': 'hostname'})
-        self.assertIn('activity', response.data)
+            params={'fields!': 'hostname'})
         self.assertNotIn('hostname', response.data)
 
     def test_list_include_fields(self):
         """Test the field inclusion/exclusion params for list."""
         response = self.authed_get(
             'machine-list',
-            params={'fields': 'activity', 'fields!': 'hostname'})
+            params={'fields!': 'hostname'})
         record = response.data['results'][0]
-        self.assertIn('activity', record)
         self.assertNotIn('hostname', record)

api/v2/views.py

@@ -82,11 +82,10 @@ class MachineViewSet(QueryFieldsMixin, viewsets.ModelViewSet):
         - Include Example: `/api/machines/?fields=console_user,hostname`
         - Exclude Example: `/api/machines/?fields!=report`
 
-    The abbreviated form excludes the `report`, `install_log`,
-    `install_log_hash`, and `activity` fields.
+    The abbreviated form excludes the `report` field.
 
     You may also use the `search` querystring to perform text searches
-    across the `activity`, `console_user`, `cpu_speed`, `cpu_type`,
+    across the `console_user`, `cpu_speed`, `cpu_type`,
     `hostname`, `machine_model`, `machine_model_friendly`, `manifest`,
     and `memory` fields.
 
@@ -104,8 +103,7 @@ class MachineViewSet(QueryFieldsMixin, viewsets.ModelViewSet):
         - Include Example: `/api/machines/C0DEADBEEF/?fields=console_user,hostname`
         - Exclude Example: `/api/machines/C0DEADBEEF/?fields!=report`
 
-    The abbreviated form excludes the `activity`, `report`, `install_log`, and
-    `install_log_hash` fields.
+    The abbreviated form excludes the `report` field.
     """
     queryset = Machine.objects.all()
     serializer_class = MachineSerializer

catalog/views.py

@@ -13,6 +13,7 @@
 from django.template import Context, RequestContext, Template
 from django.template.context_processors import csrf
 from django.views.decorators.csrf import csrf_exempt
+from django.views.decorators.http import require_POST
 
 from models import *
 from sal.decorators import *
@@ -22,11 +23,9 @@
 
 
 @csrf_exempt
+@require_POST
 @key_auth_required
 def submit_catalog(request):
-    if request.method != 'POST':
-        raise Http404
-
     submission = request.POST
     key = submission.get('key')
     name = submission.get('name')
@@ -58,12 +57,9 @@ def submit_catalog(request):
 
 
 @csrf_exempt
+@require_POST
 @key_auth_required
 def catalog_hash(request):
-    if request.method != 'POST':
-        print 'method not post'
-        raise Http404
-
     output = []
     submission = request.POST
     key = submission.get('key')

inventory/fixtures/machine_fixture.json

@@ -23,16 +23,13 @@
         "last_checkin": "2016-10-06T19:29:38.376Z",
         "first_checkin": "2016-10-06T15:51:21.145Z",
         "report": "",
-        "report_format": "base64bz2",
         "errors": 4,
         "warnings": 7,
-        "activity": "",
+        "activity": false,
         "puppet_version": "4.7.0",
         "sal_version": "1.0.6",
         "last_puppet_run": "2016-10-06T19:06:21Z",
         "puppet_errors": 0,
-        "install_log_hash": "ed168dbcf43e8c89ec3bc1a5708a7210cfeeedf0fc4e8cbbda2e0b50af782e72",
-        "install_log": "",
         "deployed": true,
         "broken_client": false
     }
@@ -61,16 +58,13 @@
         "last_checkin": "2017-05-16T19:04:51.336Z",
         "first_checkin": "2017-05-16T19:04:51.728Z",
         "report": "",
-        "report_format": "base64bz2",
         "errors": 0,
         "warnings": 3,
-        "activity": "",
+        "activity": false,
         "puppet_version": "4.10.1",
         "sal_version": "2.0.3",
         "last_puppet_run": "2017-05-16T18:54:56Z",
         "puppet_errors": 0,
-        "install_log_hash": null,
-        "install_log": null,
         "deployed": true,
         "broken_client": false
     }

inventory/views.py

@@ -18,6 +18,7 @@
 from django.template import RequestContext
 from django.utils import timezone
 from django.views.decorators.csrf import csrf_exempt
+from django.views.decorators.http import require_POST
 from django.views.generic import DetailView, View
 
 from datatableview import Datatable
@@ -524,11 +525,9 @@ def get_machine_entry(self, item, queryset):
 
 
 @csrf_exempt
+@require_POST
 @key_auth_required
 def inventory_submit(request):
-    if request.method != 'POST':
-        return HttpResponseNotFound('No POST data sent')
-
     # list of bundleids to ignore
     bundleid_ignorelist = [
         'com.apple.print.PrinterProxy'

profiles/views.py

@@ -12,6 +12,7 @@
 from django.shortcuts import get_object_or_404, render_to_response
 from django.utils import dateparse
 from django.views.decorators.csrf import csrf_exempt
+from django.views.decorators.http import require_POST
 
 
 # Local
@@ -24,11 +25,9 @@
 
 # Create your views here.
 @csrf_exempt
+@require_POST
 @key_auth_required
 def submit_profiles(request):
-    if request.method != 'POST':
-        return HttpResponseNotFound('No POST data sent')
-
     submission = request.POST
     serial = submission.get('serial').upper()
     machine = None

sal/plugin.py

@@ -31,11 +31,11 @@
 from yapsy.IPlugin import IPlugin
 import yapsy.PluginManager
 
+from django.conf import settings
 from django.http import Http404
 from django.shortcuts import get_object_or_404
 from django.template import loader
 
-from sal import settings
 from sal.decorators import handle_access, is_global_admin
 from server.models import Machine, Plugin, MachineDetailPlugin, Report
 from server.text_utils import class_to_title

search/forms.py

@@ -23,9 +23,7 @@ class SearchRowForm(forms.ModelForm):
         'activity',
         'errors',
         'warnings',
-        'install_log',
-        'puppet_errors',
-        'install_log_hash'
+        'puppet_errors'
     ]
     search_fields = []
     for f in Machine._meta.fields:

search/management/commands/search_maintenance.py

@@ -38,9 +38,7 @@ def handle(self, *args, **options):
             'activity',
             'errors',
             'warnings',
-            'install_log',
-            'puppet_errors',
-            'install_log_hash'
+            'puppet_errors'
         ]
 
         inventory_fields = [

search/views.py

@@ -57,11 +57,8 @@ def quick_search(machines, query_string):
         'activity',
         'errors',
         'warnings',
-        'install_log',
         'puppet_errors',
-        'install_log_hash',
         'deployed',
-        'report_format',
         'broken_client',
         'hd_percent',
         'memory',
@@ -582,9 +579,6 @@ def get_csv_row(machine, facter_headers, condition_headers, plugin_script_header
     skip_fields = [
         'id',
         'report',
-        'activity',
-        'install_log',
-        'install_log_hash',
         'machine_group'
     ]
     for name, value in machine.get_fields():
@@ -609,8 +603,7 @@ def stream_csv(header_row, machines, facter_headers, condition_headers, plugin_s
 
 @login_required
 def export_csv(request, search_id):
-    machines = Machine.objects.all().defer('report', 'activity', 'install_log',
-                                           'install_log_hash')
+    machines = Machine.objects.all().defer('report')
 
     machines = search_machines(search_id, machines, full=True)
 
@@ -624,9 +617,6 @@ def export_csv(request, search_id):
     skip_fields = [
         'id',
         'report',
-        'activity',
-        'install_log',
-        'install_log_hash'
     ]
     for field in fields:
         if not field.is_relation and field.name not in skip_fields:

server/admin.py

@@ -135,10 +135,9 @@ class MachineAdmin(admin.ModelAdmin):
         ('last_checkin', 'first_checkin'),
         ('puppet_version', 'last_puppet_run', 'puppet_errors'),
         ('sal_version', 'deployed', 'broken_client'),
-        'report', 'report_format', 'install_log_hash', 'install_log'
+        'report'
     )
-    readonly_fields = (business_unit, 'first_checkin', 'last_checkin', 'last_puppet_run',
-                       'report_format')
+    readonly_fields = (business_unit, 'first_checkin', 'last_checkin', 'last_puppet_run')
     search_fields = ('hostname', 'console_user')
 
 

server/migrations/0069_remove_machine_install_log.py

@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11 on 2018-04-20 17:39
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('server', '0068_auto_20180313_1440'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='machine',
+            name='install_log',
+        ),
+    ]

server/migrations/0070_remove_machine_install_log_hash.py

@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11 on 2018-04-25 18:29
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('server', '0069_remove_machine_install_log'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='machine',
+            name='install_log_hash',
+        ),
+    ]

server/migrations/0071_remove_updatehistory_pending_recorded.py

@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11 on 2018-04-25 18:36
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('server', '0070_remove_machine_install_log_hash'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='updatehistory',
+            name='pending_recorded',
+        ),
+    ]