Fix #298 #299
Merged
Fix #298 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a few changes to the checkin ManagedInstalls processing logic. - Don't create a pending UpdateHistoryItem for already installed items. - Use the Munki run's `StartTime` instead of the server's time at check-in to create pending items. - Clean out out-of-date datetime parsing for install/removal results. - Only create new UpdateHistoryItems when they are newer than the last existing item, in addition to the other checks (this is the main one solving the #298 issue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes to the checkin ManagedInstalls processing
logic.
StartTimeinstead of the server's time atcheck-in to create pending items.
existing item, in addition to the other checks (this is the main one
solving the Checkin causes sporadic IntegrityError exceptions #298 issue).